ENH: Merge multiple static libs into singe one #2533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is verified, please try it. CI failed because of no space left on device. |
wangkuiyi
approved these changes
Jun 21, 2017
| if (cc_library_DEPS) | ||
| merge_static_libs(${TARGET_NAME} ${cc_library_DEPS}) | ||
| else() | ||
| message(FATAL "Please specify source file or library in cc_library.") |
There was a problem hiding this comment.
How about changing the error message to be "cc_library requires at least SRCS or DEPS"?
| # tensor.cc | ||
| # DEPS | ||
| # variant) | ||
| function(merge_static_libs TARGET_NAME) |
| if (nv_library_DEPS) | ||
| merge_static_libs(${TARGET_NAME} ${nv_library_DEPS}) | ||
| else() | ||
| message(FATAL "Please specify source file or library in nv_library.") |
There was a problem hiding this comment.
How about "nv_library requires at least SRCS or DEPS"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENHANCEMENT:
If we have lots of source files under framework folder, each of them will invoke
cc_library(filename SRC ...)to generate *.a, finally, we must provide a target nameframework(framework.a) for the outside usage.Therefore, we need to merge multiple small libraries into larger one
libframework.a. This PR is to solve this problem.For example,
If you want to merge
libddim.aandlibplace.a... into libframework.a, you can usecc_libraryas follows:After this PR be merged, we can completely refactor the underlying building system of Paddle.