-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete Ref & VectorRef and add GetDataSafely #22997
Merged
chenwhql
merged 10 commits into
PaddlePaddle:develop
from
chenwhql:easyuse/del_ref_vectorref
Apr 4, 2020
Merged
Delete Ref & VectorRef and add GetDataSafely #22997
chenwhql
merged 10 commits into
PaddlePaddle:develop
from
chenwhql:easyuse/del_ref_vectorref
Apr 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenwhql
changed the title
Delete invalid check inferface Ref & VectorRef
Delete Mar 31, 2020
Ref & VectorRef
and add PADDLE_GET_DATA_SAFELY
chenwhql
changed the title
Delete
Delete Ref & VectorRef and add PADDLE_GET_DATA_SAFELY
Mar 31, 2020
Ref & VectorRef
and add PADDLE_GET_DATA_SAFELY
chenwhql
changed the title
Delete Ref & VectorRef and add PADDLE_GET_DATA_SAFELY
Delete Ref & VectorRef and add PADDLE GET DATA SAFELY
Mar 31, 2020
chenwhql
changed the title
Delete Ref & VectorRef and add PADDLE GET DATA SAFELY
Delete Ref & VectorRef and add GetDataSafely
Mar 31, 2020
luotao1
approved these changes
Apr 4, 2020
sneaxiy
approved these changes
Apr 4, 2020
raindrops2sea
approved these changes
Apr 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mapingshuo
pushed a commit
to mapingshuo/Paddle
that referenced
this pull request
Apr 7, 2020
* delete invalid check inferface Ref & VectorRef, test=develop * fix vector ref delete error, test=develop * try the new check inferface, test=develop * change all related code with new check macro, test=develop * remove static assert, test=develop * polish detail, test=develop * skip coverage problem, test=develop * add new check macro, test=develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR revome two invalid error check interface, and add a valid error check interface:
not change the code logic, only enhances the error message
Remove
Ref & VectorRef
check (remove safe_ref.h)Ref & VectorRef
are used to safely obtain the data pointed to by a pointer. Before* ptr
, they will check whether the pointer isnullptr
. but...Ref & VectorRef
cannot tell users the actual error pointerRef & VectorRef
cannot tell users the actual error file & line numberexample:
a
, notptr
!enforce_test.cc:369
, notsafe_ref.h:28
!Add
GET_DATA_SAFELY
enforce.h
to replaceRef & VectorRef
, resolve all above problems!GET_DATA_SAFELY
macro, and pass in 3 key word, you can get a complete and accurate error message