Simplify fluid api for fit a line #10301
Conversation
|
|
| return | ||
|
|
||
| place = fluid.CUDAPlace(0) if use_cuda else fluid.CPUPlace() | ||
| exe = fluid.Executor(place) |
There was a problem hiding this comment.
I think the purpose of this API Simplification effort is to hide details like Executor.
There was a problem hiding this comment.
Yes. The infer is in old format for a reason. #10426
I will change it to new API once it is implemented. The current PR only changed trainer.train()
There was a problem hiding this comment.
@daming-lu : You could take a look at Jeff's PR: https://github.com/PaddlePaddle/Paddle/pull/10308/files#diff-07faf3656ed1409403fcb2bb7e00f455R93
There was a problem hiding this comment.
@sidgoyal78 Thanks Sid. I kept the old infer() on purpose. I want the test to be OK with new trainer.train and old infer.
|
@daming-lu Please take a look at #10248 for your reference. Thanks! |
| return avg_loss | ||
|
|
||
|
|
||
| def train(use_cuda, save_dirname, is_local): |
There was a problem hiding this comment.
is_local is unused. What is it?
There was a problem hiding this comment.
Yes. Removed. Also triggered TeamCity
| # NOT clear yet | ||
| # fluid.io.save_inference_model(save_dirname, ['x'], [y_predict]) | ||
| # trainer.save_params(save_dirname) | ||
| trainer.save_inference_model(save_dirname) |
There was a problem hiding this comment.
This is the correct way to save model now. See here
|
@tonyyang-svail Thanks to YangYang for the bug fix. It was a tricky one 😭 |
There was a problem hiding this comment.
LGTM. Thanks, @daming-lu , this would be a good start to migrate to the new API.
modified
test_fit_a_line.pyto follow the new pattern here