fix bugs under kSgdSparseCpuTraining mode #100
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Zrachel
commented
Sep 20, 2016
Zrachel
commented
- Local training with "sparse_update = True" parameter triggers kSgdSparseCpuTraining mode, fix bugs under it.
emailweixu
requested changes
Sep 20, 2016
| @@ -141,7 +141,7 @@ void SgdThreadUpdater::traverse(GetTraverseCallback getTraverseCallback) { | |||
| } else if (hasCpuPara) { | |||
| getGlobalSyncThreadPool()->exec(cpuTraverse); | |||
| } else if (hasGpuPara) { | |||
| cpuTraverse(0, 0); | |||
| getGlobalSyncThreadPool()->exec(gpuTraverse); | |||
There was a problem hiding this comment.
should be just "gpuTraverse(0,0)", otherwise line131-133 might be executed multiple times.
Local training with "sparse_update = True" parameter triggers kSgdSparseCpuTraining mode, fix bugs under it.
|
I've correct the issue above within the same commit, Please check it. |
Closed
zhhsplendid
pushed a commit
to zhhsplendid/Paddle
that referenced
this pull request
Sep 25, 2019
…te-doc Update contribute_to_paddle.md
Closed
thisjiang
pushed a commit
to thisjiang/Paddle
that referenced
this pull request
Oct 28, 2021
…ions. (PaddlePaddle#100) * add arithmatic expr cmp * add tests to cas * add Mod support to CAS
wangxicoding
pushed a commit
to wangxicoding/Paddle
that referenced
this pull request
Dec 9, 2021
* Fixed encoding bugs. * modify docs * Fixed bugs.
zhoutianzi666
pushed a commit
to zhoutianzi666/Paddle
that referenced
this pull request
May 23, 2022
update x86_linux_demo's model to 2.0
qizhaoaoe
pushed a commit
to qizhaoaoe/Paddle
that referenced
this pull request
Mar 3, 2023
laipaang
pushed a commit
to laipaang/Paddle
that referenced
this pull request
Dec 11, 2023
lizexu123
pushed a commit
to lizexu123/Paddle
that referenced
this pull request
Feb 23, 2024
jack603047588
pushed a commit
to jiaoxuewu/PaddleBox
that referenced
this pull request
Oct 29, 2024
Support xpu3 compile.
WAYKEN-TSE
pushed a commit
to WAYKEN-TSE/Paddle
that referenced
this pull request
Dec 6, 2024
[Appflow] add Minigpt4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.