Hardened settings safety #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Paciente8159
commented
Oct 8, 2024
•
Paciente8159
commented
- added in RAM variables for work coordinates
- Improved settings safety locks. In case of detecting a setting load error the machine locks on requiring the user to reconfigure the machine
- separation of options to enable settings extra commands $SS $SR and $SL and the $P command
- modified settings logic to prevent unnecessary re-entrances and multiple store calls
- removed settings_load and settings_save events (deprecated)
- added new overritable methods to read and store data in nvm
- fixed settings change table access indexing bug
- refactoring settings code for safety preventing settings reset without the user being fully aware
Paciente8159
added
new feature: core
- modified propagation events for settings
- fixed coordinate systems save error that prevented in memory values update - fixed write error flag on save error - remove g92 from in memory coordinate settings (duplicate)
- replaced settings load/save events in favor of nvm overridable callbacks to implement settings read/write - fixed parser load coords for UNO - reordered config
Paciente8159
added
tested: OK
- fixed settings indexing modify access - fixed read error on direct startup blocks reading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.