Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved installation instructions #142

Closed
wants to merge 1 commit into from
Closed

Improved installation instructions #142

wants to merge 1 commit into from

Conversation

pietrodn
Copy link
Contributor

  1. Add instructions about how to install on macOS.
  2. Cython must be installed before pyfftw, otherwise the installation may fail on macOS.
  3. The usage of a virtual environment is recommended, to isolate the dependencies.

A proper setup.py file would be better, but I see that there is already an open PR that introduces Pipenv.

@bkueng
Copy link
Member

bkueng commented Nov 12, 2018

A proper setup.py file would be better, but I see that there is already an open PR that introduces Pipenv.

Exactly, so I'm holding off with this to get #137 in first. @mrpollo fyi.

@mrpollo
Copy link
Contributor

mrpollo commented Nov 12, 2018

Looks like some of your concerns are covered by #137 @pietrodn, would love your feedback on my PR.

@pietrodn pietrodn mentioned this pull request Nov 12, 2018
Merged
@pietrodn
Copy link
Contributor Author

Superseded by #137.

@pietrodn pietrodn closed this Nov 17, 2018
@pietrodn pietrodn deleted the readme-installation branch November 17, 2018 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pietrodn @bkueng @mrpollo