Skip to content

Commit

Permalink
ci: enable pylint add helpful messages
Browse files Browse the repository at this point in the history
  • Loading branch information
mrpollo authored and bkueng committed Nov 16, 2018
1 parent ab5a057 commit a9344f8
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 17 deletions.
17 changes: 4 additions & 13 deletions run_pylint.sh
Original file line number Diff line number Diff line change
@@ -1,14 +1,5 @@
#! /bin/bash
# execute pylint on the source

pylint_exec=$(which pylint 2>/dev/null)

[[ $? != 0 ]] && { echo >&2 "pylint not found. Aborting."; exit 1; }

set -e

export PYTHONPATH=plot_app
python $pylint_exec tornado_handlers/*.py serve.py \
plot_app/*.py download_logs.py

exit 0
PYTHONPATH=plot_app pipenv run pylint serve.py \
download_logs.py \
tornado_handlers/*.py \
plot_app/*.py
11 changes: 7 additions & 4 deletions run_tests.sh
Original file line number Diff line number Diff line change
@@ -1,11 +1,14 @@
#!/bin/bash

set -e
echo "[$(date)] Starting tests."

echo "[$(date)] Validating python dependency match"
# Check requirements lock file
pipenv lock --requirements > local-requirements.txt
cmp --silent requirements.txt local-requirements.txt || echo "ERROR: Pipenv.lock difers from requirements.txt"
cmp --silent requirements.txt local-requirements.txt || echo "[$(date)] ERROR: Pipenv.lock difers from requirements.txt"

# Check pylint
# TODO: fix pylint on source and enable
#bash run_pylint.sh
echo "[$(date)] Running pylint"
bash run_pylint.sh

echo "[$(date)] End of test script."

0 comments on commit a9344f8

Please sign in to comment.