Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overall CI container clean-up #352

Merged
merged 6 commits into from
May 17, 2024
Merged

Overall CI container clean-up #352

merged 6 commits into from
May 17, 2024

Conversation

TSC21
Copy link
Member

@TSC21 TSC21 commented May 16, 2024

Overall clean-up and restore of the containers. Details can be found in the commits.

@TSC21 TSC21 requested a review from dagar May 16, 2024 16:22
@TSC21 TSC21 force-pushed the noetic_pymavlink branch 4 times, most recently from 842f1c9 to e0e94c2 Compare May 16, 2024 17:20
@TSC21 TSC21 changed the title noetic: install pymavlink Overall CI container clean-up May 16, 2024
@TSC21 TSC21 marked this pull request as draft May 16, 2024 17:43
@TSC21 TSC21 force-pushed the noetic_pymavlink branch 5 times, most recently from 077b982 to effee7a Compare May 16, 2024 23:05
@TSC21 TSC21 marked this pull request as ready for review May 16, 2024 23:05
@dagar
Copy link
Member

dagar commented May 17, 2024

Looks good.

As a side note I think we could have a single unified Dockerfile in PX4-Autopilot itself that covers the ~99% use case (px4 nuttx + sitl + minimal ROS 2 + sim) and it would drastically simplify quite a lot.

@dagar dagar merged commit 942d817 into master May 17, 2024
22 of 23 checks passed
@dagar dagar deleted the noetic_pymavlink branch May 17, 2024 12:44
@TSC21
Copy link
Member Author

TSC21 commented May 17, 2024

Looks good.

As a side note I think we could have a single unified Dockerfile in PX4-Autopilot itself that covers the ~99% use case (px4 nuttx + sitl + minimal ROS 2 + sim) and it would drastically simplify quite a lot.

I agree. I think these for now help people also check what's possible to use and do. so happy to maintain them as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants