Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maximum height above ground (HAGL) check to all Navigator modes #23542

Merged
merged 2 commits into from
Aug 16, 2024

Conversation

bresch
Copy link
Member

@bresch bresch commented Aug 14, 2024

Solved Problem

The HAGL navigator failsafe I added in #23501 should be used in all navigator modes.

Solution

Centralize the check instead of adding it to each mode separately.

Changelog Entry

For release notes:

Add maximum height above ground (HAGL) check to all Navigator modes
New parameter: -
Documentation: -

Test coverage

  • SITL tests

Copy link
Contributor

@sfuhrer sfuhrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree that we should aim for a generic solution and not have them custom for RTL/Takeoff. Some comments from testing in SITL:

  • the reporting of the HAGL failsafe is a bit rough. E.g. it says it will switch to Hold when it already is in Hold, and it doesn't apply the timeout
    image
  • doesn't seem to work with MC Orbit
  • RTL wih OF only: why does it 3 times switch into RTL before then going to Land?
    image

src/modules/navigator/mission_block.cpp Outdated Show resolved Hide resolved
src/modules/navigator/mission_block.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@sfuhrer sfuhrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, the extension to not have the delay when switching to Hold seems correct. For my other comments:

doesn't seem to work with MC Orbit

Okay that is expected and not easy to change, as the Orbit doesn't use the triplet at all

RTL wih OF only: why does it 3 times switch into RTL before then going to Land?

That was actually the GCS sending the command 3 times.

@bresch bresch merged commit ad1d9e1 into main Aug 16, 2024
95 of 96 checks passed
@bresch bresch deleted the pr-navigator-failsafe branch August 16, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants