Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1D and 3D tests for boundary conditions #38

Merged
merged 6 commits into from
Aug 28, 2024
Merged

Add 1D and 3D tests for boundary conditions #38

merged 6 commits into from
Aug 28, 2024

Conversation

luraess
Copy link
Member

@luraess luraess commented Aug 28, 2024

Fixes #37

@luraess
Copy link
Member Author

luraess commented Aug 28, 2024

Catching this in extending test to 1D and 3D would be good.

@utkinis utkinis changed the title Handle insert_dim in the 1D case Add 1D and 3D tests for boundary conditions Aug 28, 2024
@utkinis utkinis merged commit 4eab90f into main Aug 28, 2024
1 of 12 checks passed
@utkinis utkinis deleted the lr/fixup branch August 28, 2024 22:18
@utkinis
Copy link
Member

utkinis commented Aug 28, 2024

Thanks for adding the tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dirichlet BC don't work in 1D
2 participants