Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Improving documentation #24

Merged
merged 84 commits into from
Jul 25, 2024
Merged

Conversation

youwuyou
Copy link
Collaborator

@youwuyou youwuyou commented Jun 13, 2024

This PR aims to add documentation for https://ptsolvers.github.io/Chmy.jl/dev/ and addresses the first and second TODOs in the issue #23.

  • improve documentation
  • add a basic user guide

@youwuyou youwuyou added the documentation Improvements or additions to documentation label Jun 13, 2024
@youwuyou youwuyou self-assigned this Jun 14, 2024
@@ -8,7 +8,8 @@ makedocs(
authors="Ivan Utkin, Ludovic Räss and contributors",
format = Documenter.HTML(
prettyurls=get(ENV, "CI", nothing) == "true", # easier local build
ansicolor=true
ansicolor=true,
assets = ["assets/favicon.ico"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah cool - thanks for adding this missing step

@@ -16,7 +16,7 @@ Introducing the diffusion flux $q$, we can rewrite equation `(1)` as a system of

```math
\begin{align}
\boldsymbol{q} &= -\chi \nabla C~, \\
\boldsymbol{q} &= -\chi \nabla C~, \\[5pt]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some spacing between the equations. There seems to be some rendering issues with the equation number in the margin (independently of adding spacing or not) in Safari.

Screenshot 2024-07-23 at 21 49 50

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue seems to be the align environment. I don't know if this is a bug in LaTex rendering or Documenter, reverting for now to multiple equations

@utkinis
Copy link
Member

utkinis commented Jul 25, 2024

Ok, it's been brewing long enough, merging now. Thanks everyone for the contributions =)

@utkinis utkinis merged commit 653396c into main Jul 25, 2024
9 checks passed
@utkinis utkinis deleted the yw/test-documentation branch July 25, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants