Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feeback generator node #59

Merged
merged 6 commits into from
Jul 5, 2022
Merged

Conversation

hdefazio
Copy link
Contributor

First version of the feedback generator node
Naive object tracking: Maps uuids to each class label, does not consider multiples of objects
Bug fix: swaps the top and bottom points in order to be correctly aligned

Optional reviewer @Purg

@hdefazio hdefazio changed the title Draft: feeback generator node Feeback generator node Jun 27, 2022
@hdefazio
Copy link
Contributor Author

@joshanderson-kw PTAL

tmux/feedback_generator_debug.yml Outdated Show resolved Hide resolved
tmux/feedback_generator_debug.yml Outdated Show resolved Hide resolved

detection.stamp = object_msg.source_stamp

detection.bbox = BoundingBox3D()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possibly some unfortunate foreshadowing: I remember there being an issue with the Unity app compilation because of the use of this message type. This type is defined in the vision_msgs package that the Windows ecosystem does not have access to, so it fails to resolve this reference. We may need to re-define this message type locally in angel_msgs for the Unity ROS message transpile to be happy.

ros/angel_msgs/msg/ObjectDetection3dSet.msg Outdated Show resolved Hide resolved
@hdefazio
Copy link
Contributor Author

hdefazio commented Jul 4, 2022

@Purg / @joshanderson-kw this is ready for another look

@joshanderson-kw
Copy link
Contributor

LGTM! My only other question/comment would be if we want to use the BoundingBox3D from vision_msgs, or redefine it locally in angel_msgs, like @Purg mentioned. Or do we want to save that for another PR?

@hdefazio
Copy link
Contributor Author

hdefazio commented Jul 5, 2022

LGTM! My only other question/comment would be if we want to use the BoundingBox3D from vision_msgs, or redefine it locally in angel_msgs, like @Purg mentioned. Or do we want to save that for another PR?

I figured this would be a different PR

@Purg
Copy link
Member

Purg commented Jul 5, 2022

LGTM! My only other question/comment would be if we want to use the BoundingBox3D from vision_msgs, or redefine it locally in angel_msgs, like @Purg mentioned. Or do we want to save that for another PR?

I figured this would be a different PR

Yeah, different PR.

@Purg Purg merged commit 8dcfe69 into PTG-Kitware:master Jul 5, 2022
@hdefazio hdefazio deleted the dev/feedback_gen branch July 5, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants