-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feeback generator node #59
Conversation
7c04289
to
cb2e501
Compare
@joshanderson-kw PTAL |
ros/angel_system_nodes/angel_system_nodes/feedback_generator.py
Outdated
Show resolved
Hide resolved
|
||
detection.stamp = object_msg.source_stamp | ||
|
||
detection.bbox = BoundingBox3D() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possibly some unfortunate foreshadowing: I remember there being an issue with the Unity app compilation because of the use of this message type. This type is defined in the vision_msgs
package that the Windows ecosystem does not have access to, so it fails to resolve this reference. We may need to re-define this message type locally in angel_msgs for the Unity ROS message transpile to be happy.
ros/angel_system_nodes/angel_system_nodes/feedback_generator.py
Outdated
Show resolved
Hide resolved
ros/angel_system_nodes/angel_system_nodes/feedback_generator.py
Outdated
Show resolved
Hide resolved
ros/angel_system_nodes/angel_system_nodes/feedback_generator.py
Outdated
Show resolved
Hide resolved
ros/angel_system_nodes/angel_system_nodes/feedback_generator.py
Outdated
Show resolved
Hide resolved
bebfbc3
to
cf16960
Compare
@Purg / @joshanderson-kw this is ready for another look |
ros/angel_system_nodes/angel_system_nodes/feedback_generator.py
Outdated
Show resolved
Hide resolved
LGTM! My only other question/comment would be if we want to use the |
I figured this would be a different PR |
Yeah, different PR. |
First version of the feedback generator node
Naive object tracking: Maps uuids to each class label, does not consider multiples of objects
Bug fix: swaps the top and bottom points in order to be correctly aligned
Optional reviewer @Purg