Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: implement From<&'a serde_json::Value> for Value<'a> #18

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

ssddOnTop
Copy link
Contributor

we already have a function to convert Value to serde_json::Value

but in many cases conversion from From<&'a serde_json::Value> to Value<'a> is quite useful especially when there is almost 0 allocation.

@ssddOnTop
Copy link
Contributor Author

@PSeitz can I get a quick review pls

@PSeitz PSeitz merged commit 37ab9d3 into PSeitz:main Jun 29, 2024
1 check passed
@PSeitz
Copy link
Owner

PSeitz commented Jun 29, 2024

Thanks, that makes sense to add

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants