Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add versioning with versioneer #80

Merged
merged 1 commit into from
Dec 16, 2014
Merged

Conversation

talumbau
Copy link
Member

Adding support for versioneer a nice way of doing versioning. The installed package will be able to report its version, which will be useful for reporting results in the webapp.

@MattHJensen
Copy link
Contributor

nice!

@talumbau
Copy link
Member Author

merging so I can attempt a test release.

talumbau added a commit that referenced this pull request Dec 16, 2014
add versioning with versioneer
@talumbau talumbau merged commit 9253790 into PSLmodels:master Dec 16, 2014
@MattHJensen
Copy link
Contributor

@hdoupe, is versioneer.py still used for reporting versions on the webapp?

cc @martinholmer

@hdoupe
Copy link
Collaborator

hdoupe commented Oct 16, 2018

No, the version is hard-coded. However, this is not a good solution. I sometimes forget to update the version. Something like versioneer.py would be nice to have for the webapp. This was last discussed in ospc-org/ospc.org#622 (comment)

@MattHJensen
Copy link
Contributor

@hdoupe, sorry I wasn't very clear. What I meant was, does the webapp need Tax-Calculator to have versioneer.py. Otherwise @martinholmer and I would like to delete this file. Is it ok for me to delete versioneer.py from Tax-Calculator?

@hdoupe
Copy link
Collaborator

hdoupe commented Oct 16, 2018

Ohh, I see. Nope, the webapp doesn't require that Tax-Calculator have versioneer, but Tax-Calculator should report it's version in some way that can be accessed programmatically.

@martinholmer
Copy link
Collaborator

@MattHJensen and @hdoupe,
After working some on PR #2087, it is now clear that versioneer.py (and some other files I don't understand) are necessary for the repository. So, now I know what's necessary and what's not, but several of the necessary files are mysteries to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants