Add ability to use array suffixes in JSON reform files #1505
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request, which follows up #1503, implements the idea suggested by @talumbau in TaxBrain issue 596. This Tax-Calculator enhancement should enable a major simplification in TaxBrain logic and the elimination of at least one TaxBrain bug (the one discussed in issue 596).
See the three new
test_translate_json_reform_suffixes_*
test in thetest_calculate.py
file for details on how this enhancement can be used. The new capability is optional in the sense that all old JSON reform files continue to work as they did before. The new optional capability is meant primarily for TaxBrain, but could be used in hand-written JSON reform files.@MattHJensen @feenberg @Amy-Xu @andersonfrailey @hdoupe @GoFroggyRun @codykallen
@talumbau @PeterDSteinberg @brittainhard