Filter unsectioned Tax-Calc params from C/S #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As an FYI, some of the tests are failing because of (I believe) issues unrelated to this PR. I'm happy to close this PR for now or just hold off on merging until we sort the tests out. |
|
@Peter-Metz #89 looks good. Do the tests pass locally with the updated environment in PR #91? |
|
@hdoupe yep, the tests are passing locally with the exception of |
|
Cool, thanks @Peter-Metz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion in Tax-Calc #2374, this PR filters out the unsectioned Tax-Calculator parameters in the Tax-Brain web app
cc: @andersonfrailey @hdoupe