Fix COMP Graph #83
Merged
Fix COMP Graph #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The graph that Tax-Brain produces for COMP has an error. When you click on the the "base" or "reform" buttons so that only one or the other set of lines is displayed, the baseline payroll tax line is displayed with the reform lines and the reform payroll tax line is displayed with the base lines.
The lines have always been labeled correctly and there are no issues with the accuracy of the graph.
Thanks to @Peter-Metz for pointing this bug out awhile back!
I also went ahead and updated the COMP install instructions to ensure that Tax-Calculator 2.5 or above would be installed.
cc @hdoupe