Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update agents #44

Merged
merged 2 commits into from
Oct 14, 2024
Merged

Update agents #44

merged 2 commits into from
Oct 14, 2024

Conversation

cavis
Copy link
Member

@cavis cavis commented Oct 14, 2024

No description provided.

type: Smart Home
os: Arduino
examples:
- ESP32 HTTP Client/1.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm mostly sure these are from Yoto ... but they're not overriding the default UA from this IoT framework.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Espressif and ESP are probably too broad to use for a single app. They are used all over the place.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't call this an app ... just type and os. Or do you think those aren't going to be accurate either?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making any sort of OS call for an ESP32 device is going to be tough, if the only thing we know is that its an ESP32 decice. Most run freeRTOS I think, if they have an OS at all. I don't think it would generally be accurate to call the OS Arduino, maybe ever.

Type=Smart Home is probably the closest thing we have, though likely used in this way would lead to some inaccuracies. Something like IoT, MCU or Embdedded could be better.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, os gone!

Left as smart-home for now, just to have something there.

@cavis cavis requested a review from farski October 14, 2024 16:31
@cavis cavis merged commit 2f9491c into main Oct 14, 2024
4 checks passed
@cavis cavis deleted the feat/update_agents_again branch October 14, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants