Guard for deleted episodes

PRX · Oct 17, 2024 · ccc9c62 · ccc9c62
1 parent 9e361ca
commit ccc9c62
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 3 deletions.
diff --git a/app/controllers/episodes_controller.rb b/app/controllers/episodes_controller.rb
@@ -92,7 +92,7 @@ def destroy
 
     respond_to do |format|
       if @episode.destroy
-        @episode.podcast.publish!
+        @episode.publish!
         format.html { redirect_to podcast_episodes_url(@episode.podcast_id), notice: t(".notice") }
       else
         format.html do

diff --git a/app/models/apple/episode_delivery_status.rb b/app/models/apple/episode_delivery_status.rb
@@ -1,6 +1,6 @@
 module Apple
   class EpisodeDeliveryStatus < ApplicationRecord
-    belongs_to :episode, class_name: "::Episode"
+    belongs_to :episode, -> { with_deleted }, class_name: "::Episode"
 
     def self.update_status(episode, attrs)
       new_status = (episode.apple_episode_delivery_status&.dup || new(episode: episode))

diff --git a/test/factories/apple_episode_factory.rb b/test/factories/apple_episode_factory.rb
@@ -11,7 +11,11 @@
 
     # set a complete episode factory varient
     factory :uploaded_apple_episode do
-      feeder_episode { create(:episode, apple_episode_delivery_statuses: [Apple::EpisodeDeliveryStatus.new(delivered: true)]) }
+      feeder_episode do
+        ep = create(:episode)
+        ep.apple_has_delivery!
+        ep
+      end
       transient do
         api_response do
           build(:apple_episode_api_response,

diff --git a/test/models/apple/episode_delivery_status_test.rb b/test/models/apple/episode_delivery_status_test.rb
@@ -9,6 +9,15 @@ class Apple::EpisodeDeliveryStatusTest < ActiveSupport::TestCase
       it "belongs to an episode" do
         assert_equal episode, delivery_status.episode
       end
+
+      it "can belong to deleted episodes" do
+        episode.destroy
+        assert_equal episode, delivery_status.episode
+        assert_difference "Apple::EpisodeDeliveryStatus.count", +1 do
+          episode.apple_needs_delivery!
+        end
+        assert_equal episode, episode.apple_episode_delivery_statuses.first.episode
+      end
     end
 
     describe "scopes" do