Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add hexadecimal numerical notation #3654

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Conversation

vanillajonathan
Copy link
Collaborator

@vanillajonathan vanillajonathan commented Oct 11, 2023

This lets you use hexadecimal notation to express numbers so you can do:

from products
filter status_flag == 0xff

Copy link
Member

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, could you add tests for this?

@vanillajonathan
Copy link
Collaborator Author

Thanks, could you add tests for this?

Done!

Copy link
Member

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update!

Copy link
Member

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @vanillajonathan !

Would be great to have this as a line in an example on the numbers page in the book, fine to do as a follow-up

@max-sixty max-sixty merged commit a731d86 into PRQL:main Oct 11, 2023
33 checks passed
@vanillajonathan vanillajonathan deleted the patch-2 branch October 11, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants