Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(prqlc): bump MSRV to 1.70.0 #3521

Merged
merged 2 commits into from
Sep 17, 2023
Merged

Conversation

eitsupi
Copy link
Member

@eitsupi eitsupi commented Sep 17, 2023

prqlc can now be binary installed on each platform.

I think the some of current problem with MSRV in dependencies is the prqlc dependency (#3520), so I think it makes sense to only update prqlc's MSRV.

@eitsupi eitsupi marked this pull request as ready for review September 17, 2023 04:35
@max-sixty
Copy link
Member

Ah, brilliant!

Because we don't mind about Debian for prqlc, only for prqlr, and prqlr only requires prql-compiler?

This will make managing dependencies much easier...

@eitsupi
Copy link
Member Author

eitsupi commented Sep 17, 2023

Because we don't mind about Debian for prqlc, only for prqlr, and prqlr only requires prql-compiler?

Of course I think there is value in keeping MSRV small, but I thought it was worth thinking about this since clap's MSRV is now 1.70.

  • prql-compiler needs to worry about downstream projects, but prqlc doesn't need to worry about downstream projects, so I think the impact of MSRV is small.
  • prqlc has binaries in Homebrew and the official GitHub release, so I think many people install it from there.

@eitsupi
Copy link
Member Author

eitsupi commented Sep 17, 2023

By the way, Debian testing is now on the migration from rustc 1.67 to 1.69, and 1.70 is now experimental, so there is a possibility that it will be updated to 1.70 soon.
https://tracker.debian.org/pkg/rustc

Ubuntu LTSs are 1.66 now.
https://launchpad.net/ubuntu/+source/rustc

@max-sixty
Copy link
Member

Of course I think there is value in keeping MSRV small, but I thought it was worth thinking about this since clap's MSRV is now 1.70.

Yes very much agree.

To confirm though — is the main reason we stay on a lower version because of prqlr on debian? And not prqlc?

@eitsupi
Copy link
Member Author

eitsupi commented Sep 17, 2023

To confirm though — is the main reason we stay on a lower version because of prqlr on debian? And not prqlc?

At least that's true for me.
Of course I'm monitoring Debian's rustc version, so as soon as they reach 1.70 I'll make changes here as well.
(I think setting it to 1.70 makes sense since many crates are starting to set MSRV to 1.70.)

@max-sixty
Copy link
Member

At least that's true for me. Of course I'm monitoring Debian's rustc version, so as soon as they reach 1.70 I'll make changes here as well. (I think setting it to 1.70 makes sense since many crates are starting to set MSRV to 1.70.)

Perfect, thanks for the clarification and agree.

@eitsupi eitsupi merged commit cf7f406 into PRQL:main Sep 17, 2023
73 checks passed
@eitsupi eitsupi deleted the prqlc-rust-version branch September 17, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants