Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prql-python): implement get_targets function #1838

Merged
merged 5 commits into from
Feb 15, 2023
Merged

feat(prql-python): implement get_targets function #1838

merged 5 commits into from
Feb 15, 2023

Conversation

eitsupi
Copy link
Member

@eitsupi eitsupi commented Feb 14, 2023

Same as prql-js.

prql/prql-js/src/lib.rs

Lines 69 to 74 in 0406d1a

pub fn get_targets() -> Vec<JsValue> {
prql_compiler::Target::names()
.iter()
.map(|t| JsValue::from_str(t))
.collect()
}

eitsupi
eitsupi commented Feb 14, 2023
View reviewed changes
prql-python/src/lib.rs Outdated Show resolved Hide resolved
max-sixty
max-sixty approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@max-sixty max-sixty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent @eitsupi !

prql-python/python/tests/test_all.py Outdated Show resolved Hide resolved
@eitsupi eitsupi enabled auto-merge (squash) February 15, 2023 09:34
@eitsupi eitsupi merged commit 95a3305 into PRQL:main Feb 15, 2023
@eitsupi eitsupi mentioned this pull request Feb 15, 2023
Closed
@eitsupi eitsupi deleted the python-target-names branch February 16, 2023 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-sixty max-sixty max-sixty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eitsupi @max-sixty