Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require agreement to the Code of Conduct before publishing feedback #1973

Closed
thewilkybarkid opened this issue Sep 30, 2024 · 0 comments
Closed

Comments

@thewilkybarkid
Copy link
Member

No description provided.

thewilkybarkid added a commit that referenced this issue Oct 1, 2024
thewilkybarkid added a commit that referenced this issue Oct 1, 2024
thewilkybarkid added a commit that referenced this issue Oct 1, 2024
thewilkybarkid added a commit that referenced this issue Oct 1, 2024
Note this is not enforced, and there's no UI to do so.

Refs #1973
thewilkybarkid added a commit that referenced this issue Oct 1, 2024
thewilkybarkid added a commit that referenced this issue Oct 1, 2024
thewilkybarkid added a commit that referenced this issue Oct 1, 2024
Note that the page is unlinked.

Refs #1973
thewilkybarkid added a commit that referenced this issue Oct 2, 2024
thewilkybarkid added a commit that referenced this issue Oct 2, 2024
As the Effect server catches defects and returns a 500 response, we need to see when this happens.

Refs #1834, #1973
thewilkybarkid added a commit that referenced this issue Oct 3, 2024
There's a bug in the `@effect/sql-libsql` library where transactions don't work with a libSQL server. This has broken in the sandbox, but not locally where SQLite is used. This commit removes transactions temporarily to allow the sandbox to be used, as it's still feature-flagged and is solely for testing at the moment.

Refs #1973, b041ac1, Effect-TS/effect#3709
thewilkybarkid added a commit that referenced this issue Oct 3, 2024
thewilkybarkid added a commit that referenced this issue Oct 9, 2024
thewilkybarkid added a commit that referenced this issue Oct 9, 2024
The tests began to fail when re-enabling transactions as they're incompatible with in-memory SQLite databases. It should be possible to use `file::memory:?cache=shared` rather than `:memory:`, but this also doesn't entirely. To avoid spending more time on this problem, this commit uses temporary file-based databases in the tests.

Refs #1973, 3acf814, tursodatabase/libsql-client-ts#229, https://www.sqlite.org/inmemorydb.html
thewilkybarkid added a commit that referenced this issue Oct 10, 2024
Rather than persisting `_tag` in the `payload` field, this change uses the `event_type` field to be independent of Effect's data structure.

Refs #1973
thewilkybarkid added a commit that referenced this issue Oct 10, 2024
Currently, the resource type is stored with each event. It would be better to store this in a single place.

Refs #1973
thewilkybarkid added a commit that referenced this issue Oct 10, 2024
thewilkybarkid added a commit that referenced this issue Oct 10, 2024
thewilkybarkid added a commit that referenced this issue Oct 31, 2024
thewilkybarkid added a commit that referenced this issue Oct 31, 2024
thewilkybarkid added a commit that referenced this issue Oct 31, 2024
Prettier added whitespace, which seems to have meaning in Firefox and WebKit. Adding `summary::marker { white-space-collapse: collapse }` should fix this, but WebKit doesn't support this. I can't think of another way around it other than turning off Prettier for the whole element.

Refs #1973, 866522e, https://bugs.webkit.org/show_bug.cgi?id=204163
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant