Fix issue in the read_ros2_messages calling #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeoBrizi
requested review from
nachovizzo,
benemer and
tizianoGuadagnino
as code owners
|
@LeoBrizi ciao, can we get the data to have a look what is actually going on? |
|
here's to you |
|
Hola, sorry for the delay. We have been off for some time for personal reasons, but we just managed to have a look. It looks acceptable to me. Thanks for the bug fix. |
tizianoGuadagnino
approved these changes
Oct 9, 2024
nachovizzo
approved these changes
Oct 9, 2024
benemer
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read_ros2_messages function takes a list of topics as input. In some cases, this may be a problem. As in this case, I executed it by simply typing:
kiss_icp_pipeline /home/leonardo/tesla_dataset/rosbag2_2023_11_18-14_56_27_0.mcap