Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create stale.yml #52

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from
Open

Create stale.yml #52

wants to merge 1 commit into from

Conversation

maximilien
Copy link
Contributor

As per TAC call today creating this GH action that will mark issues and PRs as stalled if they have no comments after some period of time

As per TAC call today creating this GH action that will mark issues and PRs as stalled if they have no comments after some period of time

Signed-off-by: dr.max <[email protected]>
@maximilien
Copy link
Contributor Author

CC: @brian-jarvis-aws @n1ckl0sk0rtge @planetf1 @ryjones @KennyPaul for any feedback and approval to merge

- uses: actions/stale@v5
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
stale-issue-message: 'Stale issue message'
Copy link

@n1ckl0sk0rtge n1ckl0sk0rtge Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stale-issue-message: 'Stale issue message'
stale-issue-message: 'This issue has been automatically marked as stale due to inactivity. It will be closed if no further activity occurs within 7 days. Thank you for your contributions.'

with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
stale-issue-message: 'Stale issue message'
stale-pr-message: 'Stale pull request message'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stale-pr-message: 'Stale pull request message'
stale-pr-message: 'This pull request has been automatically marked as stale due to lack of recent updates. It will be closed if no further activity occurs within 7 days. Please review and update if needed.'

Copy link

@n1ckl0sk0rtge n1ckl0sk0rtge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe adding more meaningful comments.


steps:
- uses: actions/stale@v5
with:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand the action correctly, I think some parameters are missing. According to the docs, I'd expect at least days-before-stale and days-before-close.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the defaults for those are 60/7

Two values I've used before areexempt-pr-labels / exempt-issue-labels . Though there is an argument this can be overused (it was in my previous project), so the group may prefer that this has to be done by adding an explanation as to why, and manually re-opening

Copy link
Contributor

@planetf1 planetf1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with proposed change. there are comments, but actioning imo is optional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants