Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test-case #326

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Added test-case #326

wants to merge 1 commit into from

Conversation

m8pple
Copy link
Contributor

@m8pple m8pple commented Jul 14, 2022

Test-case for #325

@m8pple m8pple mentioned this pull request Jul 14, 2022
Open
mvousden
mvousden requested changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@mvousden mvousden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good test case, but we should integrate it as part of a fix. Before merging (perhaps as part of this PR):

  • Add the test case (as you have so eloquently done)
  • Ensure it's marked as 'xpass' in the suite
  • Fix the parsing logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvousden mvousden mvousden requested changes

Assignees

@m8pple m8pple

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m8pple @mvousden