Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Talkative mothership interface #253

Merged
merged 27 commits into from
Jun 23, 2021
Merged

Talkative mothership interface #253

merged 27 commits into from
Jun 23, 2021

Conversation

mvousden
Copy link
Contributor

@mvousden mvousden commented Jun 22, 2021 •
edited
Loading

Resolves #245.

This changeset:

  • Causes Motherships to post on application state transition (even outside debug mode!).
  • Changes the existing acknowledgement system in Root to Post when all Motherships have reached a certain state. This changeset adds some fields to OrchBase to facilitate this.
  • Causes the deployment command to write useful information to its microlog.
  • Causes Motherships to propagate errors to each other, via Root (logging as appropriate).
  • Fixes a bug where Motherships would print their close-down message outside debug mode.

Notably, it does not:

  • Introduce a time-out for deployment and initialisation. It'd take too long to get right, and it's fiddly because it depends on the application being loaded.
  • Support recalling of an initialised or running application (as usual). You'll need to start/stop the application first.

This changeset was tested with the ring_test example on Ayres, using thread-filling and bucket-filling placement.

Also see the documentation PR at POETSII/orchestrator-documentation#18

mvousden added 26 commits June 18, 2021 08:24
@mvousden
WIP: More logserver/microlog output from deployment staging.
386772c
@mvousden
Compilable!
69e5436
@mvousden
More talkative Mothership, outside debug mode.
f32ff59
@mvousden
Fix whitespace and comment inconsistency.
2099341
@mvousden
Make Root more chatty when it receives acknowledgements from a Mother…
ac17435 
…ship.
@mvousden
More todos.
4a3a708
@mvousden
Add new message keyset so processes can communicate about broken appl…
7e1a5d1 
…ications.
@mvousden
Change helper structures to use strings instead of graph instance poi…
22c70ee 
…nters.

They're difficult to get hold of from only the application name.
@mvousden
Mothership sends a cool new message to Root when an app is broken.
95428d9
@mvousden
Make root register when an app is broken.
4dff1ea
@mvousden
Update todo list
d344b42
@mvousden
Add CMND,BRKN message, and use it to allow Motherships (and Root) to …
0535db1 
…propagate error states to each other.
@mvousden
Another todo
1139699
@mvousden
Allow recall messages to recall applications that are marked as broken.
c1d61e3
@mvousden
Clear deployment state (including ERROR) in Root when all Motherships…
a9bf655 
… confirm they have recalled an application.
@mvousden
Executive decision.
9f959a4
@mvousden
Nope, not doing that either.
42d575b
@mvousden
Remove an unused deployment state.
5b8b406
@mvousden
Better UX, by feel.
d543f14
@mvousden
Better microlog text.
1902a6f
@mvousden
More posting for various Mothership-related commands.
d3d6a26
@mvousden
Merge branch 'development' into FEATURE-0245-talkative-mothership-int…
aceec56 
…erface
@mvousden
Better communication, more consistent map keys.
139e67a
@mvousden
Only print Mothership closing message in debug mode.
76858b1
@mvousden
Update the todo list.
335b1de
@mvousden
Remove todo list.
62414c1
@mvousden mvousden requested a review from heliosfa June 22, 2021 14:32
@mvousden mvousden self-assigned this Jun 22, 2021
@mvousden mvousden mentioned this pull request Jun 22, 2021
Merged
@heliosfa heliosfa mentioned this pull request Jun 23, 2021
Closed
@mvousden mvousden mentioned this pull request Jun 23, 2021
Merged
heliosfa
heliosfa approved these changes Jun 23, 2021
View reviewed changes
Source/Mothership/Mothership.cpp
/* Sends a message to Root explaining that an app is broken. */
void Mothership::tell_root_app_is_broken(std::string appName)
{
PMsg_p sadTidings;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Source/OrchBase/OrchBaseMothership.cpp
@@ -86,14 +86,36 @@ void OrchBase::MshipCommand(Cli::Cl_t clause, std::string command)

/* Set up the message given the input arguments (catching an invalid
* command input from somewhere). */
if (command == "reca")
int postIndex = 999; /* These defaults can never be used. */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am glad you default to something valid but obtuse!

@mvousden mvousden merged commit b2e6707 into development Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heliosfa heliosfa heliosfa approved these changes

Assignees

@mvousden mvousden

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploy and Init do not Post on success/failure
2 participants
@mvousden @heliosfa