Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional send through doSend is not supported #309

Open
m8pple opened this issue Jan 13, 2022 · 2 comments · May be fixed by #297
Open

Conditional send through doSend is not supported #309

m8pple opened this issue Jan 13, 2022 · 2 comments · May be fixed by #297
Assignees
Labels
bug Report of a bug

Comments

@m8pple
Copy link
Contributor

m8pple commented Jan 13, 2022

Some applications request the opportunity to send, but then can choose not to:

https://github.com/POETSII/poets_improvement_proposals/blob/438757c772dfa26cecd56b2856c6c2e180308530/proposed/PIP-0020/virtual-graph-schema-v4.rnc#L500

This is sometimes used when it is expensive to work out when to send (essentially you have to construct the whole
packet first), or if you want to do something based on time, so you don't want to do it in the RTS handler. I think
Shane also used it in his firefly stuff.

It's also used in the clock_tree_broad and deep apps from the benchmark/stress tests. Probably some others too,
I haven't looked at them all. The doSend flag pre-dates OnCompute, which pre-dates OnDeviceIdle, which would
cover some use-cases these days.

@m8pple
Copy link
Contributor Author

m8pple commented Jan 13, 2022

Also used in the "airfoil" finite element app from the stress tests. Oh well.

@heliosfa
Copy link
Contributor

I recall looking at this before after we talked about it and thinking it would be "quick win" but then remembered that the buffering mode ADB requested complicated matters. This should not be too difficult to implement once I am off papers.

@heliosfa heliosfa self-assigned this Jan 13, 2022
@heliosfa heliosfa added the bug Report of a bug label Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of a bug
Projects
None yet
2 participants