Merging dev onto release #2890
Merged
Merging dev onto release #2890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update docs with example on network extraction #docs
Adding porespy to docs requirements so it'll be available for examples.
tutorials #1 to 10
the typos of examples #1-10 (excluding porosity and extracted) network are fixed.
Fixing typos in tutorials
Updated pore surface area calculation models #bug
# Conflicts: # openpnm/__version__.py # setup.cfg
Fixing spacing in BCC network #bug
More robust conduit length models #bug
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release #2890 +/- ##
=========================================
- Coverage 89.9% 89.8% -0.1%
=========================================
Files 148 148
Lines 8608 8646 +38
=========================================
+ Hits 7742 7768 +26
- Misses 866 878 +12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.