Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CromwellConfiguration Services is not written to janis run cromwell config #67

Closed
rlupat opened this issue Oct 27, 2021 · 0 comments · Fixed by #68
Closed

CromwellConfiguration Services is not written to janis run cromwell config #67

rlupat opened this issue Oct 27, 2021 · 0 comments · Fixed by #68
Assignees
@rlupat

Comments

@rlupat
Copy link
Member

rlupat commented Oct 27, 2021 •
edited
Loading

Multiple problems:

  • CromwellConfiguration class init is missing services object.
  • The current setup of MetadataService object is also not serializable.
  • Hence, Cromwell Config in SlurmSingularity template has never been carried over to the actual cromwell.conf on janis-managed cromwell instances (e.g. the config for increasing the metadata read_row_number_safety_threshold)
@rlupat rlupat self-assigned this Oct 27, 2021
@rlupat rlupat mentioned this issue Nov 19, 2021
Merged
rlupat added a commit that referenced this issue Nov 19, 2021
@rlupat
Merge pull request #68 from PMCC-BioinformaticsCore/67-bugfix-cromwel…
594bf1a 
…l-config

bugfix #67 cromwell config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlupat rlupat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugfix #67 cromwell config PMCC-BioinformaticsCore/janis-assistant
1 participant
@rlupat