Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mis-web): 充值记录页面搜索条件的时间筛选与账户/租户条件筛选交互不一致 #974

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

piccaSun
Copy link
Contributor

@piccaSun piccaSun commented Nov 13, 2023

修改前

租户管理与平台管理下的账户/租户充值记录页面
时间条件的筛选后只有点击搜索才生效
租户/账户筛选时直接发送api请求,造成了二者交互不一致

选择时间后不点击搜索,筛选账户发送了API请求,但是请求参数不是当前选择的时间
image

经与产品老师沟通,此PR修改为充值记录页面所有条件单独筛选时不发送请求,点击搜索时才发送请求

修改后

所有条件的筛选都需要点击搜索才能生效
chrome-capture-2023-10-13

Copy link

changeset-bot bot commented Nov 13, 2023

🦋 Changeset detected

Latest commit: c274839

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@scow/mis-web Patch
@scow/auth Patch
@scow/gateway Patch
@scow/mis-server Patch
@scow/portal-server Patch
@scow/portal-web Patch
@scow/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (135f2b1) 68.28% compared to head (c274839) 68.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #974   +/-   ##
=======================================
  Coverage   68.28%   68.28%           
=======================================
  Files         134      134           
  Lines        3998     3998           
  Branches      535      535           
=======================================
  Hits         2730     2730           
  Misses       1170     1170           
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@piccaSun piccaSun requested a review from ddadaal November 13, 2023 05:59
@ddadaal ddadaal merged commit e20be6f into master Nov 13, 2023
10 checks passed
@ddadaal ddadaal deleted the fix-pay-search-filter branch November 13, 2023 13:38
Miracle575 pushed a commit that referenced this pull request Jan 12, 2024
### 修改前

租户管理与平台管理下的账户/租户充值记录页面
时间条件的筛选后只有点击搜索才生效
租户/账户筛选时直接发送api请求,造成了二者交互不一致

选择时间后不点击搜索,筛选账户发送了API请求,但是请求参数不是当前选择的时间

![image](https://github.com/PKUHPC/SCOW/assets/43978285/623c28b7-9da3-4bce-914a-fcc02c541109)


经与产品老师沟通,此PR修改为充值记录页面所有条件单独筛选时不发送请求,点击搜索时才发送请求

### 修改后
所有条件的筛选都需要点击搜索才能生效

![chrome-capture-2023-10-13](https://github.com/PKUHPC/SCOW/assets/43978285/dd44aa5c-b224-4b51-8248-ba55514e712a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants