fix(mis-web): 修复 scow 仅可以提交当前作业的用户来取消作业 #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fcbc6e4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Miracle575
changed the title
Miracle575
changed the title
Miracle575
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #972 +/- ##
=======================================
Coverage 68.28% 68.28%
=======================================
Files 134 134
Lines 3998 3998
Branches 535 535
=======================================
Hits 2730 2730
Misses 1170 1170
Partials 98 98 ☔ View full report in Codecov by Sentry. |
Miracle575
added a commit
that referenced
this pull request
Jan 12, 2024
修复 scow 管理系统仅可 以提交当前作业的用户来取消作业，考虑从 scow 做完全的鉴权，不放开适配器权限 slurm adapter 取消作业时会 `su userId scancel xxx`，所以不能提交执行当前操作的用户 id 来取消作业。 scow 会先校验当前用户的权限，如果具有取消用户作业的权限，则获取提交当前作业的用户，使用该用户 userId 来取消作业
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复 scow 管理系统仅可 以提交当前作业的用户来取消作业，考虑从 scow 做完全的鉴权，不放开适配器权限
slurm adapter 取消作业时会
su userId scancel xxx，所以不能提交执行当前操作的用户 id 来取消作业。scow 会先校验当前用户的权限，如果具有取消用户作业的权限，则获取提交当前作业的用户，使用该用户 userId 来取消作业