Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mis): 管理系统未结束作业新增结束操作 #968

Merged
merged 1 commit into from
Nov 11, 2023

Conversation

Miracle575
Copy link
Contributor

@Miracle575 Miracle575 commented Nov 10, 2023

与门户系统类似,新增结束作业操作
image
与门户系统不同,增加了权限校验:

const { job, jobAccessible } = await checkJobAccessible(jobId, cluster, info);

if (jobAccessible === "NotAllowed") {
  return { 403: null };
} else if (jobAccessible === "NotFound") {
  return { 404: { code: "JOB_NOT_FOUND" } as const };
}

Copy link

changeset-bot bot commented Nov 10, 2023

🦋 Changeset detected

Latest commit: 9ac8368

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@scow/mis-server Minor
@scow/mis-web Minor
@scow/grpc-api Minor
@scow/protos Patch
@scow/lib-hook Patch
@scow/lib-operation-log Patch
@scow/lib-scheduler-adapter Patch
@scow/audit-server Patch
@scow/portal-server Minor
@scow/portal-web Minor
@scow/auth Minor
@scow/gateway Minor
@scow/cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a79aa10) 68.50% compared to head (9ac8368) 68.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #968   +/-   ##
=======================================
  Coverage   68.50%   68.50%           
=======================================
  Files         134      134           
  Lines        3978     3978           
  Branches      530      530           
=======================================
  Hits         2725     2725           
  Misses       1155     1155           
  Partials       98       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Miracle575 Miracle575 marked this pull request as ready for review November 10, 2023 07:05
@Miracle575 Miracle575 requested a review from ddadaal November 10, 2023 07:05
@ddadaal ddadaal merged commit f6f84b6 into master Nov 11, 2023
10 checks passed
@ddadaal ddadaal deleted the feat-cancel-job branch November 11, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants