Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lib): 创建家目录时设置权限为740 #953

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

ZihanChen821
Copy link
Contributor

@ZihanChen821 ZihanChen821 commented Nov 7, 2023

改动:
insertKeyAsRoot时会创建家目录,之前的权限默认为755, 不希望其他用户可以读以及访问该家目录,故创建家目录时设定权限为740

结果:
新用户创建后家目录如下
image

Copy link

changeset-bot bot commented Nov 7, 2023

🦋 Changeset detected

Latest commit: aceba0d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@scow/lib-ssh Patch
@scow/auth Patch
@scow/mis-server Patch
@scow/portal-server Patch
@scow/portal-web Patch
@scow/gateway Patch
@scow/mis-web Patch
@scow/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e1e3230) 68.89% compared to head (aceba0d) 68.90%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #953   +/-   ##
=======================================
  Coverage   68.89%   68.90%           
=======================================
  Files         132      132           
  Lines        3926     3927    +1     
  Branches      523      523           
=======================================
+ Hits         2705     2706    +1     
  Misses       1123     1123           
  Partials       98       98           
Files Coverage Δ
libs/ssh/src/key.ts 90.00% <100.00%> (+0.16%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZihanChen821 ZihanChen821 marked this pull request as ready for review November 7, 2023 06:01
Copy link
Member

@ddadaal ddadaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么要740?在PR里解释一下

@ZihanChen821 ZihanChen821 requested a review from ddadaal November 8, 2023 01:38
@ddadaal ddadaal merged commit f42488e into master Nov 8, 2023
11 checks passed
@ddadaal ddadaal deleted the feat-home-dir-chomod-740 branch November 8, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants