Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: github worflow新增push PKU repository #708

Merged
merged 6 commits into from
Jul 4, 2023
Merged

Conversation

ZihanChen821
Copy link
Contributor

@ZihanChen821 ZihanChen821 commented Jun 27, 2023

改动:

  1. 在现有的workflow下,在Test, Build and Publish Projects内的build images job里新增使用账号密码docker login 到PKU_CR:mirrors.eecser.com,此账号密码保存在github secrets内,key分别为PKUREGISTRY_USERNAMEPKUREGISTRY_PASSWORD
  2. 将build好的image上传至mirrors.eecser.com/pkuhpc-icode/xxx: {tag}
  3. 通过mirror.pku.edu.cn/pkuhpc-icode/xxx: {tag}可以拉到最新push到mirrors.eecser.com/pkuhpc-icode/xxx: {tag}的镜像

自测:
已在58集群拉取到该image
image

关于push的速度问题: 经测试偶尔时间达到将近十多分钟,可以考虑后续只对release或者合master的image 推到该仓库,其他pr的image继续使用github的仓库即可。

@changeset-bot
Copy link

changeset-bot bot commented Jun 27, 2023

⚠️ No Changeset found

Latest commit: fe3b481

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (99e2b08) 65.12% compared to head (fe3b481) 65.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #708   +/-   ##
=======================================
  Coverage   65.12%   65.12%           
=======================================
  Files         129      129           
  Lines        3773     3773           
  Branches      500      500           
=======================================
  Hits         2457     2457           
  Misses       1249     1249           
  Partials       67       67           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ZihanChen821 ZihanChen821 changed the title test(cli): 测试github worflow新增PKU repository feat(cli): github worflow新增push PKU repository Jun 29, 2023
@ZihanChen821 ZihanChen821 changed the title feat(cli): github worflow新增push PKU repository ci: github worflow新增push PKU repository Jun 29, 2023
@ZihanChen821 ZihanChen821 requested a review from ddadaal June 29, 2023 05:35
@ZihanChen821 ZihanChen821 marked this pull request as ready for review June 29, 2023 05:35
@ddadaal
Copy link
Member

ddadaal commented Jun 30, 2023

push速度的问题影响到 #710 (comment)

@ddadaal ddadaal merged commit c9723cc into master Jul 4, 2023
@ddadaal ddadaal deleted the test-push-image-pku-cr branch July 4, 2023 08:03
ddadaal added a commit that referenced this pull request Jul 21, 2023
回滚#708。由于github actions访问北大镜像库速度较慢,故此PR使CI时不push镜像到北大镜像库中。北大镜像库
中通过webhook和镜像的方式从ghcr中同步镜像。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants