-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(portal): 增加文件上传限制可配置功能 #524
Conversation
🦋 Changeset detectedLatest commit: 72d33a3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #524 +/- ##
=======================================
Coverage 67.03% 67.03%
=======================================
Files 115 115
Lines 3134 3134
Branches 391 391
=======================================
Hits 2101 2101
Misses 980 980
Partials 53 53 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
e65ee9c
to
bad5de4
Compare
PR描述里写清楚如何写这个配置,不要让用户看代码才能知道。 |
用户部署配置:
修改scow-deployment/config.py文件中的网关配置,取消对GATEWAY 的注释,修改UPLOAD_FILE_SIZE_LIMIT的值,如将默认的1G改为50M:
PR合并前测试步骤,用户部署无需关注:
1、与正常流程一样拉取镜像
2、修改scow-deployment 下的config.py文件,参照用户部署配置,可将UPLOAD_FILE_SIZE_LIMIT的值改为其它值,例如5M。
3、PR未被合并前,还需要修改scow-deployment 下的generate.py,增加了对UPLOAD_FILE_SIZE_LIMIT的配置,具体参考此PR对deploy/local/generate.py文件的修改,复制即可。
4、进入文件管理,点击文件上传,展示了文件上传的最大限制。尝试上传1个10M的文件,失败