Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(portal-web): 修复文件管理跳转路径导致的控制台报错 #1015

Merged
merged 2 commits into from
Nov 30, 2023

Conversation

Miracle575
Copy link
Contributor

@Miracle575 Miracle575 commented Nov 29, 2023

image

// return <Redirect url={`/files/${cluster}/${data?.path ?? ""}`} />;
return <Redirect url={join("/files", cluster, data?.path ?? "")} />;

Copy link

changeset-bot bot commented Nov 29, 2023

🦋 Changeset detected

Latest commit: 7842520

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@scow/portal-web Patch
@scow/auth Patch
@scow/gateway Patch
@scow/mis-server Patch
@scow/mis-web Patch
@scow/portal-server Patch
@scow/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bbbb9d9) 68.36% compared to head (7842520) 68.36%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1015   +/-   ##
=======================================
  Coverage   68.36%   68.36%           
=======================================
  Files         133      133           
  Lines        3935     3935           
  Branches      521      521           
=======================================
  Hits         2690     2690           
  Misses       1148     1148           
  Partials       97       97           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Miracle575 Miracle575 marked this pull request as ready for review November 30, 2023 01:27
@Miracle575 Miracle575 requested a review from ddadaal November 30, 2023 01:27
@ddadaal ddadaal merged commit 9a47c21 into master Nov 30, 2023
12 checks passed
@ddadaal ddadaal deleted the fix-file-path branch November 30, 2023 13:32
Miracle575 added a commit that referenced this pull request Jan 12, 2024
![image](https://github.com/PKUHPC/SCOW/assets/140392039/12d0dcd6-d855-4d80-ac3b-98d735304e57)
```typescript
// return <Redirect url={`/files/${cluster}/${data?.path ?? ""}`} />;
return <Redirect url={join("/files", cluster, data?.path ?? "")} />;
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants