Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mis): 修复平台管理页面用户列表的用户统计错误 #1013

Merged
merged 4 commits into from
Nov 29, 2023

Conversation

ZihanChen821
Copy link
Contributor

现状:

  1. 平台管理页面下的AllUserTable里的数据接口是后端分页,但是前端对三个tab的数据统计是根据该分页接口的该页数据过滤得到的,是不准确的。
  2. 之前的GetPlatformUsersCounts是用来适配GetAllUsers后端分页接口,但在此处fix(web): 修复 mis-web 中账户列表和用户列表页面统计数量不随搜索而变化的问题 #905 被删去,原因在于当用户填入了筛选项时,数据统计的接口并不是筛选后的情况。

改动

  1. 恢复AllUserTable里的GetPlatformUsersCounts接口,确保统计数据准确,
  2. 同时给该接口增加过滤参数,确保用户输入过滤项时的数据实时更新。

Copy link

changeset-bot bot commented Nov 28, 2023

🦋 Changeset detected

Latest commit: dfbfd9f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@scow/mis-server Patch
@scow/mis-web Patch
@scow/grpc-api Patch
@scow/protos Patch
@scow/lib-hook Patch
@scow/lib-operation-log Patch
@scow/lib-scheduler-adapter Patch
@scow/audit-server Patch
@scow/portal-server Patch
@scow/portal-web Patch
@scow/auth Patch
@scow/gateway Patch
@scow/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (bbbb9d9) 68.36% compared to head (dfbfd9f) 68.36%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1013   +/-   ##
=======================================
  Coverage   68.36%   68.36%           
=======================================
  Files         133      133           
  Lines        3935     3935           
  Branches      521      521           
=======================================
  Hits         2690     2690           
  Misses       1148     1148           
  Partials       97       97           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZihanChen821 ZihanChen821 marked this pull request as ready for review November 28, 2023 05:39
.changeset/fast-trees-draw.md Outdated Show resolved Hide resolved
.changeset/itchy-trains-play.md Outdated Show resolved Hide resolved
@ZihanChen821 ZihanChen821 requested a review from ddadaal November 29, 2023 01:09
@ddadaal ddadaal merged commit 1a1189a into master Nov 29, 2023
9 checks passed
@ddadaal ddadaal deleted the fix-all-user-table-count branch November 29, 2023 14:12
Miracle575 pushed a commit that referenced this pull request Jan 12, 2024
### 现状:
1.
平台管理页面下的AllUserTable里的数据接口是后端分页,但是前端对三个tab的数据统计是根据该分页接口的该页数据过滤得到的,是不准确的。
2. 之前的GetPlatformUsersCounts是用来适配GetAllUsers后端分页接口,但在此处#905
被删去,原因在于当用户填入了筛选项时,数据统计的接口并不是筛选后的情况。


### 改动
1. 恢复AllUserTable里的GetPlatformUsersCounts接口,确保统计数据准确,
2. 同时给该接口增加过滤参数,确保用户输入过滤项时的数据实时更新。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants