Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Bazel support #190

Open
PJK opened this issue Jul 18, 2021 · 2 comments
Open

Improve Bazel support #190

PJK opened this issue Jul 18, 2021 · 2 comments

Comments

@PJK
Copy link
Owner

PJK commented Jul 18, 2021

In increasing order of usefulness:

  • Add a full example (+ test)
  • Provide a ready to use "libcbor.BUILD"
  • Use Bazel natively (alongside cmake)
    • We would have to replicate all the defines and preprocessing, which might be painful to keep in sync, but doable

CC @andyjgf

@andyjgf
Copy link
Contributor

andyjgf commented Jul 19, 2021 via email

@PJK
Copy link
Owner Author

PJK commented Jul 23, 2021

Yeah that would be great, I think e.g. examples/bazel would make sense.

It is reasonable to start with the default value of the preprocessor defines (https://github.com/PJK/libcbor/blob/master/CMakeLists.txt#L20, except maybe CBOR_CUSTOM_ALLOC = true). There are some Windows hacks (https://github.com/PJK/libcbor/blob/master/CMakeLists.txt#L66) and environment checks, but those we can probably ignore for now.

The only 3p dependency is Cmocka for tests. It would be good if tests were also runnable from the blaze project. Is that easily doable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants