[BUG][GUI] Don't return StakingOnlyUnlocked from WalletModel::sendCoins #2104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
random-zebra
added
GUI
Bug
Needs Backport
Fuzzbawls
approved these changes
Dec 24, 2020
Fuzzbawls
pushed a commit
to Fuzzbawls/PIVX
that referenced
this pull request
Dec 27, 2020
Github-Pull: PIVX-Project#2104 Rebased-From: f79a00d
random-zebra
added a commit
that referenced
this pull request
Dec 28, 2020
41abf5a clear StakeableCoins before initializing (PeterL73) 3de9861 [Policy] Set DEFAULT_SHIELDEDTXFEE_K to 100 (from 1000) (random-zebra) 4a8e571 [BUG] Fix total budget on testnet (random-zebra) 4285bee scripted-diff: Fix "alloted" typo (random-zebra) 107529b Tests: check getbudgetinfo / getbudgetprojection updated output (random-zebra) 495c546 Tests: check invalid RPC inputs in rpc_budget test (random-zebra) 723a41b Consensus: enforce that proposal BlockStart must be a superblock (random-zebra) 5fb488a Consensus: enforce proposal max payments (6 main-net / 20 test-net) (random-zebra) 6377883 [BUG][Tests] Fix remote nodes switched ports in PivxTier2TestFramework (random-zebra) 73864a0 Startup: move masternode port validation inside `initMasternode`. (furszy) 18e83cf Only return the tx hex string in rawdelegatestake (Fuzzbawls) 85d83b1 Further RPC help output cleanups (Fuzzbawls) 2c315a3 Only Return the transaction hex string in `rawshieldsendmany` (Fuzzbawls) a6b3f77 [BUG][GUI] Cache unconfirmed_balance only for transparent outs (random-zebra) d95f0ca [BUG][GUI] Don't return StakingOnlyUnlocked from WalletModel::sendCoins (random-zebra) f17aabc [Trivial][GUI] coin control: Fixed column size in list-mode (random-zebra) f3662f8 [GUI] Finally, fix duplicate records. (furszy) 1d95c40 [DOC] main readme, added latest release version and release date badges (furszy) afcba75 [DOC] main readme, re-written to current project state. (furszy) 7fd9e62 [DOC] Readme, migrated staled travis badge for github actions status badge. (furszy) 227161b [Trivial][RPC] Drop 'ed' suffix from Shielded in TxSaplingToJSON (random-zebra) ed8999a [GUI] send screen, hide shield all coins btn for now. (furszy) Pull request description: further backports for the 5.0 branch: #2094 #2093 #2095 #2096 #2098 #2104 #2102 #2097 #2103 #2101 #2108 #2109 ACKs for top commit: furszy: utACK 41abf5a random-zebra: utACK 41abf5a and merging... Tree-SHA512: 34619594f6e87362f8760a24c39ef25e8acf856de258d1e40f5a1264381fb9e6f6210bcca2b1bc765a0366c7a4467d43c95147bf75f7c2d64d16ee3b41a9efb9
random-zebra
removed
the
Needs Backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug found in current master.
Steps to reproduce
for staking only.Issue:
Instead of sending the tx, the wallet asks again for the password, and still doesn't send the transaction (without any feedback) even when the password is entered a second time.
Cause:
By the time the flow reaches
WalletModel::sendCoins, the UnlockContext is lost, and the wallet has been relocked (for staking only) already.This is correct, as the transaction is created and signed in
WalletModel::prepareTransaction, andsendCoinsonly commits the transaction, therefore it doesn't need a fully-unlocked wallet.The function, though, currently returns early with return value
SendCoinsReturn::StakingOnlyUnlocked, if the wallet is unlocked for-staking-only, and the transaction isn't sent.Fix:
Simply remove the un-needed check in sendCoins.