Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Consensus][Validation] Reject outdated block version after v5 enforcement #2067

Merged
merged 4 commits into from
Dec 18, 2020
Merged

[Consensus][Validation] Reject outdated block version after v5 enforcement #2067

merged 4 commits into from
Dec 18, 2020

Commits on Dec 17, 2020

  1. BUG: Fix TestBlockValidity for PoW blocks 

    Especially in CreateNewBlock, where the proper nonce hasn't been mined
yet
    @random-zebra
    random-zebra committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    a6ea4e1 View commit details
    Browse the repository at this point in the history

  2. Consensus: reject blocks with outdated version (<8) after v5 enforcement

    @random-zebra
    random-zebra committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    a2e446f View commit details
    Browse the repository at this point in the history

  3. Miner: set proper block version based on upgrade enforcements

    @random-zebra
    random-zebra committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    c0819f8 View commit details
    Browse the repository at this point in the history

  4. Cleanup: remove unneeded check (time-based) for version 4 header 

    thus remove !CheckBlockHeader and directly use (fCheckPOW &&
!CheckProofOfWork)
    @random-zebra
    random-zebra committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    a4ef257 View commit details
    Browse the repository at this point in the history