Refactor: always check mnp blockhash in CMasternodePing::CheckAndUpdate

PIVX-Project · Dec 13, 2020 · c292b9a · c292b9a
1 parent c04a4c5
commit c292b9a
Showing 1 changed file with 8 additions and 8 deletions.
diff --git a/src/masternode.cpp b/src/masternode.cpp
@@ -602,6 +602,14 @@ bool CMasternodePing::CheckAndUpdate(int& nDos, bool fRequireAvailable, bool fCh
         return false;
     }
 
+    // Check if the ping block hash exists and it's within 24 blocks from the tip
+    if (!mnodeman.IsWithinDepth(blockHash, 2 * MNPING_DEPTH)) {
+        LogPrint(BCLog::MNPING,"%s: Masternode %s block hash %s is too old or has an invalid block hash\n",
+                                        __func__, vin.prevout.hash.ToString(), blockHash.ToString());
+        nDos = 33;
+        return false;
+    }
+
     // see if we have this Masternode
     CMasternode* pmn = mnodeman.Find(vin.prevout);
     const bool isMasternodeFound = (pmn != nullptr);
@@ -633,14 +641,6 @@ bool CMasternodePing::CheckAndUpdate(int& nDos, bool fRequireAvailable, bool fCh
                 return false;
             }
 
-            // Check if the ping block hash exists and it's within 24 blocks from the tip
-            if (!mnodeman.IsWithinDepth(blockHash, 2 * MNPING_DEPTH)) {
-                LogPrint(BCLog::MNPING,"%s: Masternode %s block hash %s is too old or has an invalid block hash\n",
-                                                __func__, vin.prevout.hash.ToString(), blockHash.ToString());
-                nDos = 33;
-                return false;
-            }
-
             // ping have passed the basic checks, can be updated now
             mnodeman.mapSeenMasternodePing.emplace(GetHash(), *this);