Acquire cs_vNodes before changing refrence counts

PIVX-Project · Jun 23, 2020 · 18af800 · 18af800
1 parent 7aa827f
commit 18af800
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/src/net.cpp b/src/net.cpp
@@ -891,15 +891,24 @@ static std::list<CNode*> vNodesDisconnected;
 
 class CNodeRef {
 public:
-    CNodeRef(CNode *pnode) : _pnode(pnode)  {_pnode->AddRef();}
-    ~CNodeRef() {_pnode->Release();}
+    CNodeRef(CNode *pnode) : _pnode(pnode) {
+        LOCK(cs_vNodes);
+        _pnode->AddRef();
+    }
+
+    ~CNodeRef() {
+        LOCK(cs_vNodes);
+        _pnode->Release();
+    }
 
     CNode& operator *() const {return *_pnode;};
     CNode* operator ->() const {return _pnode;};
 
     CNodeRef& operator =(const CNodeRef& other)
     {
         if (this != &other) {
+            LOCK(cs_vNodes);
+
             _pnode->Release();
             _pnode = other._pnode;
             _pnode->AddRef();
@@ -910,6 +919,7 @@ class CNodeRef {
     CNodeRef(const CNodeRef& other):
         _pnode(other._pnode)
     {
+        LOCK(cs_vNodes);
         _pnode->AddRef();
     }
 private: