93 responder #114
Merged
93 responder #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… refactored EthereumResponder and EthereumDedicatedResponder
…actoring of the test suite
yahgwai
reviewed
Apr 26, 2019
…zed timing promises.
…ecting if the transaction is stuck using the new helpers
yahgwai
reviewed
Apr 30, 2019
… parameter of the emitted events in the EthereumResponderManager
… rejectAfterBlocks
yahgwai
reviewed
May 1, 2019
yahgwai
approved these changes
May 1, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added another chunk of work to the EthereumDedicatedResponder, which is closer to a reasonably stable state. Tests are still not fully satisfactory.
Added the EthereumMultiResponder and a few tests, but it is still very preliminary.