Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added automatic correction function for conversion accuracy errors #343

Merged
merged 3 commits into from
May 7, 2023

Conversation

PINTO0309
Copy link
Owner

@PINTO0309 PINTO0309 commented May 6, 2023

1. Content and background

  • Add, Sub, Mul, Div, Mod
    • Added automatic correction function for conversion accuracy errors
    • Conversion speed is reduced instead of compensating for accuracy errors
  • Add, Sub, Mul, Div, Mod, MatMul, Softmax
    • Strict conversion mode implemented
    • However, if the input tensor has undefined dimensions, the automatic correction will not work perfectly.
    • As of 2023.05.07, this is a work in progress and is an experimental feature.
  • Added option to disable strict conversion mode
    • -dsm, --disable_strict_mode
      -dsm, --disable_strict_mode
        If specified, the conversion speed is greatly accelerated because the strict accuracy
        correction process is skipped, but the frequency of transposition errors increases
        and accuracy errors are more likely to occur. Strict mode is enabled by default.
        As of 2023.05.07, this is a work in progress and is an experimental feature.
        Therefore, only some OPs are converted in exact mode for accuracy correction.
      
  • Enable -dsm to greatly reduce the time to complete testing, as CI testing only checks the conversion structure.

2. Summary of corrections

3. Before/After (If there is an operating log that can be used as a reference)

4. Issue number (only if there is a related issue)

@PINTO0309 PINTO0309 merged commit 12ab2d4 into main May 7, 2023
@PINTO0309 PINTO0309 deleted the imp_shape_match branch May 7, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant