Find title

CHANGELOG.md

@@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](https://semver.org).
 
 ## [Unreleased] - 
 
+### Fixed 
+- Fix getSheetByName function in XLSX Worksheet - [#739](https://github.com/PHPOffice/PhpSpreadsheet/issues/739)
+
 ### Added
 
 - Added support for inline styles in Html reader (borders, alignment, width, height)

src/PhpSpreadsheet/Spreadsheet.php

@@ -721,7 +721,8 @@ public function getSheetByName($pName)
     {
         $worksheetCount = count($this->workSheetCollection);
         for ($i = 0; $i < $worksheetCount; ++$i) {
-            if ($this->workSheetCollection[$i]->getTitle() === $pName) {
+            if (($this->workSheetCollection[$i]->getTitle() === $pName)
+                 || $this->workSheetCollection[$i]->getTitle() === trim($pName, "'")) {
                 return $this->workSheetCollection[$i];
             }
         }

tests/PhpSpreadsheetTests/SpreadsheetTest.php

@@ -0,0 +1,57 @@
+<?php
+
+namespace PhpOffice\PhpSpreadsheetTests;
+
+use PhpOffice\PhpSpreadsheet\Spreadsheet;
+use PhpOffice\PhpSpreadsheet\Worksheet\Worksheet;
+use PHPUnit\Framework\TestCase;
+
+class SpreadsheetTest extends TestCase
+{
+    /** @var Spreadsheet */
+    private $object;
+
+    public function setUp()
+    {
+        parent::setUp();
+        $this->object = new Spreadsheet();
+        $sheet = $this->object->getActiveSheet();
+
+        $sheet->setTitle('someSheet1');
+        $sheet = new Worksheet();
+        $sheet->setTitle('someSheet2');
+        $this->object->addSheet($sheet);
+        $sheet = new Worksheet();
+        $sheet->setTitle('someSheet 3');
+        $this->object->addSheet($sheet);
+    }
+
+    /**
+     * @return array
+     */
+    public function dataProviderForSheetNames()
+    {
+        $array = [
+            [0, 'someSheet1'],
+            [0, "'someSheet1'"],
+            [1, 'someSheet2'],
+            [1, "'someSheet2'"],
+            [2, 'someSheet 3'],
+            [2, "'someSheet 3'"],
+        ];
+
+        return $array;
+    }
+
+    /**
+     * @param $index
+     * @param $sheetname
+     *
+     * @throws \PhpOffice\PhpSpreadsheet\Exception
+     * @dataProvider dataProviderForSheetNames
+     */
+    public function testGetSheetByName($index, $sheetname)
+    {
+        $this->assertEquals($this->object->getSheet($index), $this->object->getSheetByName($sheetname));
+    }
+}

tests/PhpSpreadsheetTests/Worksheet/WorksheetTest.php

@@ -137,6 +137,10 @@ public function extractSheetTitleProvider()
             ['B2', '', '', 'B2'],
             ['testTitle!B2', 'testTitle', 'B2', 'B2'],
             ['test!Title!B2', 'test!Title', 'B2', 'B2'],
+            ['test!Title!B2', 'test!Title', 'B2', 'B2'],
+            ["'testSheet 1'!A3", "'testSheet 1'", 'A3', 'A3'],
+            ["'testSheet1'!A2", "'testSheet1'", 'A2', 'A2'],
+            ["'testSheet 2'!A1", "'testSheet 2'", 'A1', 'A1'],
         ];
     }