Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance optimization (dupplicate call of strtoupper and multiple calls auf preg_replace) #858

Closed
wants to merge 2 commits into from

Conversation

fglueck
Copy link

@fglueck fglueck commented Jan 23, 2019

strtoupper also in setSelectedCells()

This is:

- [X] a bugfix
- [ ] a new feature

Checklist:

Why this change is needed?

Just for Performance

look at:
public function setSelectedCells($pCoordinate)
{
// Uppercase coordinate
$pCoordinate = strtoupper($pCoordinate);

strtoupper also in setSelectedCells()
little performance improvement
@fglueck fglueck changed the title Update Worksheet.php Dupplicate call of strtoupper and multiple calls auf preg_replace optimizing Jan 30, 2019
@stale
Copy link

stale bot commented Mar 31, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is still an issue for you, please try to help by debugging it further and sharing your results.
Thank you for your contributions.

@stale stale bot added the stale label Mar 31, 2019
@stale stale bot closed this Apr 7, 2019
@fglueck
Copy link
Author

fglueck commented Jun 28, 2019

is this fix not needed?

@fglueck fglueck changed the title Dupplicate call of strtoupper and multiple calls auf preg_replace optimizing Performance optimization (dupplicate call of strtoupper and multiple calls auf preg_replace) Jun 28, 2019
@oleibman
Copy link
Collaborator

getStyle no longer performs strtoupper, and the Validations class, new since this PR was introduced, combines its preg_replace calls into 1. Removing stale label, but keeping PR closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants