Issue 629 - Remove duplicate strtoupper #825
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-allan
commented
Dec 18, 2018
| // Check cell collection | ||
| if ($this->cellCollection->has(strtoupper($pCoordinate))) { | ||
| if ($this->cellCollection->has($pCoordinateUpper)) { |
There was a problem hiding this comment.
This seems like a bug to me. Shouldn't get use the same key we checked with has? Based on the code in Cells I think this can return null.
matt-allan
commented
Dec 18, 2018
| @@ -1214,17 +1217,14 @@ public function getCell($pCoordinate, $createIfNotExists = true) | |||
| } | |||
| } | |||
|
|
|||
| // Uppercase coordinate | |||
| $pCoordinate = strtoupper($pCoordinate); | |||
|
|
|||
| if (Coordinate::coordinateIsRange($pCoordinate)) { | |||
There was a problem hiding this comment.
None of these checks actually need to use the uppercase version as they are only checking for symbols, not letters.
Removing the duplicate strtoupper call has a meaningful impact on performance since this method is called at least once per cell.
guillaume-ro-fr
pushed a commit
to guillaume-ro-fr/PhpSpreadsheet
that referenced
this pull request
Jun 12, 2019
Removing the duplicate strtoupper call has a meaningful impact on performance since this method is called at least once per cell. `Worksheet::getCells` currently calls `strtoupper` twice. `strtoupper` is kind of expensive and this method is called at least once for every cell in the spreadsheet. By removing the unnecessary second call the runtime decreases by 18% when importing a ~100K cell spreadsheet. Closes PHPOffice#825
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the duplicate strtoupper call has a meaningful impact on
performance since this method is called at least once per cell.
This is:
Checklist:
Why this change is needed?
Worksheet::getCellscurrently callsstrtouppertwice.strtoupperis kind of expensive and this method is called at least once for every cell in the spreadsheet. By removing the unnecessary second call the runtime decreases by 18% when importing a ~100K cell spreadsheet.I think the line could just be changed to
$pCoordinate = strtoupper($pCoordinate)but I'm not familiar enough with the worksheet references and named ranges to be confident that won't break anything.