Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #801 libxml_disable_entity_loader() is changed #819

Closed

Conversation

philipp-kolesnikov
Copy link

- [x] a bugfix
- [ ] a new feature

Checklist:

Why this change is needed?

#802 already provides fix for #801, but scenario like this:

$reader = new \PhpOffice\PhpSpreadsheet\Reader\Xlsx();

libxml_use_internal_errors(true);
libxml_clear_errors();

$document = new DOMDocument();
$document->load("test.xml");

echo libxml_get_last_error()->message. "\n";

will still fail. This PR will fix both issues.

@PowerKiKi
Copy link
Member

Merged in 8918888

@PowerKiKi PowerKiKi closed this Jan 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants