Fix for: "!" characters in Worksheet title will make reference formulas crash #325 #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 6, 2018 16:49
…HPOffice#325 Bugfix: replace explode by "!" with special function, that extracts sheet name from reference
…HPOffice#325 add information to changelog
PowerKiKi
requested changes
Sep 28, 2018
…as crash PHPOffice#325 adding unit test for Worksheet::extractSheetTitle
PowerKiKi
approved these changes
Oct 3, 2018
|
Thanks ! |
Dfred
pushed a commit
to Dfred/PhpSpreadsheet
that referenced
this pull request
Nov 20, 2018
When extracting sheet title from string reference (like `"Work!sheet1!A1"`), PHP function `explode()` divide this string into three parts: `['Work', 'sheet1', 'A1']`. And then these wrong values are used in formulas, ranges, etc. This change fix that problem by using special function `Worksheet::extractSheetTitle()`. This function also has been changed to make sure that worksheet title can contain "!" character. So, that function search last position of "!" in reference string and divide it to 2 parts correctly: `['Work!sheet1', 'A1']`. Fixes PHPOffice#325 Fixes PHPOffice#662
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix: replace explode by "!" with special function, that extracts sheet name from reference
This is:
Checklist:
Why this change is needed?
When sheet title extracting from string reference (like "Work!sheet1!A1"), php function "explode" divide this string to three parts (['Work', 'sheet1', 'A1']). And then these wrong values using in formulas, ranges, etc.
This change fix that problem by using special function Worksheet::extractSheetTitle (this function also has been changed to make sure that worksheet title can contain "!" character). So, that function search last position of "!" in reference string and divide it to 2 parts correctly (['Work!sheet1', 'A1']).